Eslint v8 #156
Merged
Eslint v8 #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawikabader
requested review from
3rd-Eden,
DullReferenceException,
Swaagie,
burgessa23,
kinetifex and
rxmarbles
rxmarbles
approved these changes
Dec 15, 2021
msluther
reviewed
Dec 15, 2021
Contributor
msluther
left a comment
msluther
left a comment
There was a problem hiding this comment.
This feels like a new major rev to me, are there other things we'd want to do before publishing? Do we want a new minimum version of eslint? Have we tested this with using older versions?
jpage-godaddy
approved these changes
Dec 16, 2021
Contributor
jpage-godaddy
left a comment
jpage-godaddy
left a comment
There was a problem hiding this comment.
Besides the peerDependencies suggestion for eslint, looks good to me.
kinetifex
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates made to support using Eslint v8.